refactor: adjust FIND_NODE response exceptions #1158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
- restore safety check for self in closestPeersToQuery with debug logging - add spec-referencing comments for self and requester filtering - clarify FIND_PEER exception that allows self/requester in response
lidel
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
@guillaumemichel lgtm, pushed updates to comments and restored one defensive check we had in old version
i'm going to ship this in Kubo 0.38.0-rc2 to catch any unintended consequences early
lidel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust DHT Server FIND_NODE handling to match the IPFS DHT Spec ipfs/specs#497.
Changes:
selfnorrequesterin aFIND_NODEresponseFIND_NODErequest exactly matches the peer id ofselforrequester(andrequesteris in the peerstore)